Software Engineering Stack Exchange
Software Engineering Stack Exchange

Questions tagged [review]

31 questions
35
votes
1 answer

How to write "SMART" Objectives as an agile developer?

Like many corporations the company I work for is transitioning to a performance review system based on SMART objectives. My team is a high functioning agile development team employing practices from Extreme Programming. To our great benefit our…
ahsteele
  • 788
  • 1
  • 9
  • 23
28
votes
7 answers

How to monitor code review efficiently?

I suspect major code review cover up in my team. Too many code reviews are merged without any comment. Seems to me like there's no such thing as a code review without a single comment. How can I as a team lead properly monitor that my team is…
guy mograbi
  • 659
  • 8
  • 11
22
votes
4 answers

What is an example of a good SMART objective for a programmer?

Following on from this question, I wondered if folk might be able to suggest some samples of what might be considered a "good" objective in a periodic review cycle for a programmer? Let's define SMART from the most popular definitions in the…
Mike Woodhouse
  • 781
  • 1
  • 5
  • 14
8
votes
1 answer

Design review: how well does my object oriented design fit the SOLID principles?

This thread will be long, but I will try to make it as short as I can. Thank you. I have recently implemented a relatively simple program. What this program does is generate a simple piece of music and play it. I will describe the object oriented…
Aviv Cohn
  • 21,190
  • 31
  • 118
  • 178
7
votes
7 answers

Best algorithm to sort tasks by priorities by a human

I have developed a task management tool. And some task lists can be very large. (I have myself more than 300 tasks to do). I would like to do some task reviews from time to time as the tasks pile up to be able to sort them by priority. I imagine…
MickaelFM
  • 205
  • 1
  • 7
5
votes
1 answer

Architecture Review Guidelines for Java/JEE project

We're going to do a complete review of a Java/JEE based application. This includes an architecture review, code review and platform hardware review. While we're a bit aware of code review techniques, I'm wondering if there is a template or reference…
JoseK
  • 1,407
  • 12
  • 22
5
votes
5 answers

Is there a way to dispute or challenge poor iPhone app reviews?

Problem: user has left review of iPhone app which is simply incorrect Question: is there a way to make contact with the reviewer and a) explain how what they've said is incorrect and help them with their issue or b) challenge the review? Edit Sept…
Richard
  • 311
  • 2
  • 11
5
votes
5 answers

What is your code review and approval process, and what are its advantages/disadvantages?

Does your team rely on code reviews for approval of work? Is it simply QA that signs off your features and fixes? Do you have a lead programmer (or architect) that reviews code design and implementation? Or is it simply a Works on My Machine…
Edward A
4
votes
2 answers

Should PR reviews check for code correctness?

When doing PR reviews, should the reviewer be checking that the code is correct (e.g. the logic is correct, etc.) or should the only focus be higher level concepts (e.g. architectural/functional/etc.)? I've been doing a lot of code correctness…
Adam Thompson
  • 1,243
  • 1
  • 9
  • 14
4
votes
1 answer

Moving past the ignoring or considering whitespace binary: how should I compare files for e.g. commit review?

I am dissatisfied with the file comparison tools I have worked with so far. While no tool would be able to always predict the line matchings that make best sense, at least current tools should be able to do a better job when changes mostly consist…
Pierre Lebeaupin
  • 141
  • 3
4
votes
4 answers

CMS updates into subversion -> review process

We manage a range of client sites built in Wordpress and Joomla and these require regular updates to the core CMS and extensions. We keep these sites in subversion and place updates in subversion. We try to use a single revision for this. We face…
jdog
  • 280
  • 1
  • 8
3
votes
2 answers

Where can I ask for an accessibility review for a site?

I'm not too, too far (I hope) from finishing a site. I want to have it reviewed with an eye to its accessibility. The site's job is to display streaming, up-to-the-10-second-period stock-option data. Does anyone know of a group or forum where I can…
Pete Wilson
  • 1,766
  • 11
  • 15
3
votes
1 answer

Review of my OOP design for simple password manager

I'm going to write a simple password manager, which is going to store my accounts encrypted. Here is description of the classes , LoginManager - This class will be responsible for authenticating the user, since the data on the harddrive will be…
nameLess
  • 129
  • 1
  • 5
3
votes
2 answers

What do you do to articulate your benefit as a programmer in an organisation where you are a cost-centre?

In my organisation I build financial products, for mutual funds, 401Ks, life insurance and margin-loans (or the equivalent in my jurisdiction). I take feature/epic requests from product managers - plan a project, design the software changes,…
hawkeye
  • 4,819
  • 3
  • 24
  • 35
3
votes
1 answer

How to manage ratings system of my web app?

I am making a website where in users would rate posts by other users, according to how useful they are. The posts will be about products - mobiles, tablets, and other personal consumer electronics only. I want to make sure no trolling or slandering…
Tony K
  • 31
  • 2
1
2 3