Software Engineering Stack Exchange
Software Engineering Stack Exchange

Questions tagged [pull-requests]

68 questions
298
votes
6 answers

Why squash git commits for pull requests?

Why does every serious Github repo I do pull requests for want me to squash my commits into a single commit? I thought the git log was there so you could inspect all your history and see exactly what changes happened where, but squashing it pulls it…
hamstar
  • 3,091
  • 2
  • 11
  • 6
104
votes
5 answers

Should I submit a pull request to correct minor typos in a Readme file?

While going through the README file of a GitHub repository I am not a contributor of, I noticed a few minor typos and wondered if I should submit a pull request to correct them or if reviewing the request would take the maintainer too much time to…
Florent Michel
  • 1,121
  • 2
  • 4
  • 8
40
votes
2 answers

Is it better to start a Pull Request or perform a local merge commit on master?

I have been using GitHub for quite some time now and I usually used to push my feature-branches and then start a Pull Request which I myself merged. I found it helped me keep track of where I merged branches. But recently I have been reading more…
Ashhar Hasan
  • 919
  • 1
  • 8
  • 14
33
votes
5 answers

Code review workflow where pull request author must merge

Several teams at my company practice a code review workflow I've never seen before. I am trying to understand the thinking behind it, with the idea that there's value in making the whole company consistent. (I contribute to multiple codebases and…
aednichols
  • 441
  • 1
  • 4
  • 7
26
votes
4 answers

How to handle a TODO in a pull request?

When I review the changes in a pull request, I sometimes stumble upon a comment with a "TODO" note which may be there for different reasons, in our case mostly because of: the solution used to solve a problem can be improved but would require…
alecxe
  • 331
  • 4
  • 15
26
votes
5 answers

Why use pull requests instead of merging

What is the advantage of using pull requests instead of simply merging a branch into master without one? Particularly on a team where all developers have full access to master.
Goose
  • 1,858
  • 2
  • 15
  • 27
21
votes
1 answer

Should we use Reject or Wait For Author in TFS when there are things to be fixed?

In TFS, when we put comments for things to be fixed in a Pull Request before we will accept it, should we mark it as Reject or Wait For Author? Which is better?
sashoalm
  • 313
  • 1
  • 2
  • 8
17
votes
1 answer

My github pull request was merged, what's the convention at this stage?

I forked a project on Github, made a small change and sent a pull request to the original maintainer, who has pulled it in. Now the last commit there is Merged pull request #11 from my_username/master. This is the first time I'm doing this, so I'm…
Sundar R
  • 272
  • 1
  • 9
13
votes
1 answer

I accidentally overhauled someone's entire project. Any acceptable way to pull request?

I found a great project on github with a useful central feature but which is rough in the "polishing" of error handling, logging, config, and setup. The project is 5 years untouched, and only a couple hundred lines of code. Still it's useful enough…
user1169420
  • 249
  • 1
  • 4
12
votes
6 answers

Are pull requests the place for training juniors

We have a concept that all code in a Pull Request into master should be production ready. This makes sense and is a fair statement in my opinion. The idea here being that once you create the PR, you are stating that you would have put this into…
Riaan Schutte
  • 281
  • 1
  • 7
12
votes
1 answer

How to do peer reviews on GitHub pull requests?

We're moving from Bitbucket to GitHub and one thing we are struggling with are peer code reviews that worked very smoothly on Bitbucket like this: Author opened a Pull Request (GitHub: the same) Author added his/her colleagues as reviewers (GitHub:…
Borek Bernard
  • 1,075
  • 1
  • 11
  • 16
11
votes
1 answer

Why can't Pull Requests be seriously implemented in Mercurial?

A week ago, I was at LFNW and as I was talking with Larry Hastings after his talk, he said (paraphrased): There's something in Git that makes the Pull Request workflow possible that isn't there in Mercurial. That's why Pull Requests on BitBucket…
strugee
  • 221
  • 2
  • 7
11
votes
1 answer

Introducing Pull Requests for a 2 person team - merge my own requests?

I'm introducing git to a junior team member (a co-op). They are comfortable now with the basics of adding, committing, pushing and pulling. Now I want to introduce them to pull requests and branches. If they start doing pull requests in branches,…
Michael Durrant
  • 13,101
  • 5
  • 34
  • 60
9
votes
4 answers

How to handle versioning with multiple independent pull requests in a Git repository?

Let's say Alice has a Git repository, and the version is kept track of inside the repository (e.g. package.json for npm). Bob sends a pull request to Alice which increments the version number from 0.1.0 to 0.1.1. Carol also sends a pull request to…
alexia
  • 195
  • 9
8
votes
1 answer

Should I accept pull requests that are behind master?

Sometimes my project has multiple pull requests. I don't know what is the proper process to handle it. Currently what I do is Review each pull request. check code looks ok, and all comments were treated check if travis-ci passed and if github…
guy mograbi
  • 659
  • 8
  • 11
1
2 3 4 5