Doing work when passing constructor arguments

Question

This is very closely linked to the question Legitimate "real work" in a constructor? but not quite the same.

I am interested in having feedback on whether this is acceptable or has any risks. in C#, I instantiate a class:

var f = new Foo(DoSlowComplexTask());

it seems the same as doing:

var x = DoSlowComplexTask();
var f = new Foo(x);

NOTE: this is a bit different from the often asked question where we have

public class Foo{
   object workResult;
   public Foo(object someParam){
   DoSlowComplexTask(someParam);
  }
}

In both of your examples, you're doing work *outside* of the constructor, not inside it. — Robert Harvey, Oct 05 '20 at 15:47

score 2 · Accepted Answer · answered Oct 05 '20 at 10:46

If you want to use the result of DoSlowComplexTask outside the instance of Foo, sure, assigning the result to the x variable is a good idea, so that the result is ready. Otherwise the two approaches are the same, smart compiler will likely even produce the same machine code, and both of the approaches are fine.

Doing work when passing constructor arguments

1 Answers1