10

I'm currently working on introducing React in the company I work for. As the only one having done courses on the topic, who can I ask for a review to make sure the code is following 'best practices' and is implemented correctly?

Nicklas Pouey-Winger
  • 211
  • 1
  • 5
  • 6
    Aside: companies should *not* strive to reduce the bus factor to one. – Philip Kendall Feb 07 '17 at 20:18
  • Possible duplicate of [How can I make being code reviewed by someone who doesn't know the language easier?](http://softwareengineering.stackexchange.com/questions/196212/how-can-i-make-being-code-reviewed-by-someone-who-doesnt-know-the-language-easi) – gnat Feb 07 '17 at 20:38
  • 4
    Um, have the other developers take React courses? – Robert Harvey Feb 07 '17 at 20:59
  • 1
    @gnat Not a duplicate, but they are related. That question is asking what to do to make it easier for reviewers unfamiliar with a language. This one is asking who should be chosen to be part of the review. – Thomas Owens Feb 07 '17 at 21:27
  • @ThomasOwens you have a point, upon re-reading it looks like a bit different question (retracted duplicate vote) – gnat Feb 08 '17 at 10:16
  • Ignorance (but not too much maybe!) is a legitimate perspective for a code review. And I don't mean merely code formatting flame wars. – radarbob Feb 10 '17 at 22:32

1 Answers1

25

There are other reasons to do a code review. If you have developers who are familiar with similar technologies, it may be useful to hold a code review meeting where you walkthrough the code and use it as a learning experience for the rest of the team. Their questions about what you are doing may help you find problems in your own code by talking through what you implemented and how you implemented it.

Community
  • 1
Thomas Owens
  • 79,623
  • 18
  • 192
  • 283